Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit a -sys crate out #68
Conversation
|
Since when did a We are not shipping CoreFoundation.framework in Cargo packaging, so this is confusing. |
|
cc @aturon @alexcrichton for input on the community standard. I'll be really disappointed if we have to rename everything because the community took the wrong cue from Servo conventions. |
|
Beautiful. :( So now what do C packages in Cargo get called? I'll a little bit cranky that I spent a bunch of time working this out, asking @alexcrichton and others for advice, only to have the solution co-opted and documented as being something other than what was decided. Now I get to do all the work again if we want to maintain community norms, and apparently I get to come up with a new naming convention that someone may then reappropriate in the future for something else! |
alexcrichton
commented
Aug 26, 2015
|
@metajack yeah the standard is for
If the library can't actually be linked for whatever reason, it's the responsibility of the build script to print an error. In that sense the convention of Sorry if there was any miscommunication earlier, this was the intention from the get-go and something may have just been lost along the way. |
|
Rebased |
|
ping @pcwalton? |
|
I'll review this. |
|
Reviewed 30 of 43 files at r1, 1 of 1 files at r2, 9 of 9 files at r3. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
Thanks! Could you publish to Crates.io by any chance? |
|
This got published. |
Update to core-foundation 0.3 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/68) <!-- Reviewable:end -->
Bump foundation and graphics versions for #62. This removes the last of the compiler warnings. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/68) <!-- Reviewable:end -->
sfackler commentedAug 26, 2015
I used some reexports to make this move backwards compatible for current users.