Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upModernization and cleanup #69
Merged
+181
−495
Conversation
* Implement IntoIterator for &CFArray * Abstract from_CFTypes over TCFTypes
* Implement Deref for CFData * Use slice::from_raw_parts instead of transmuting a tuple
* Abstract from_CFType_pairs over TCFTypes
* Abstract from_slice over TCFType
* Add CFString::new, deprecate FromStr impl * Implement Display for CFString * Add wrapping `"`s for Debug impl
All of the manually implemented methods are identical, but can't be made default implementations unfortunately.
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on src/array.rs in 0d216f2
Sep 1, 2015
|
nit: Could you use a where clause here? |
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on src/set.rs in edaea4d
Sep 1, 2015
|
nit: Could you use a where clause here? |
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on src/string.rs in 6d5a95c
Sep 1, 2015
|
Why is this deprecated? A |
This comment has been minimized.
This comment has been minimized.
|
I'm fine leaving it around if you prefer, it just seemed a bit weird to have a |
|
Looks good, just had a couple of nits. |
|
Updated, thanks for taking a look! |
|
There's also some breaking updates I'd like to make (e.g. making the parameter to |
|
@bors-servo: r+ |
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Revert previous dependency upgrades. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/69) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sfackler commentedAug 30, 2015
Changes are split up into a set of separate commits.