Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSilence warning with minor cleanup #75
Merged
+1
−3
Conversation
|
By the way, the warning was |
|
@bors-servo r+ Nice cleanup! Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 17, 2015
Silence warning with minor cleanup <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/75) <!-- Reviewable:end -->
|
Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 20, 2016
Bump version: 0.2.0 -> 0.2.1. #77 #75 #73 #74 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/78) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Fixed runtime error in example by removing unnecessary null terminator
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Upgrade core foundation This is a PR in a series of PRs originating at #132 The plan is to make a breaking change to `core-foundation` and release it as `0.5.0`. But before the merge/publish of `core-foundation` I will prepare a set of PRs making sure the entire dependency graph of Servo is ready for this change and can be switched over to `0.5.0` directly TODO before merge: - [x] Merge `core-foundation` PR and publish. - [x] Merge `core-graphics` PR and publish. - [x] Remove the last commit from this PR, so we depend on `core-foundation` from crates.io. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-text-rs/75) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
TimNN commentedDec 17, 2015