Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CFPropertyList serialization #88
Closed
Conversation
|
Can you split the formatting changes and the rest of changes in different commits? That'll make it easier to review :) @bors-servo r? @jdm |
|
Done! |
added 2 commits
Jan 2, 2017
|
Reopening on a feature branch |
ghost
closed this
ghost
mentioned this pull request
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2017
Add CFPropertyList serialization Tests included. Reopened from #88 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/90) <!-- Reviewable:end -->
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Add CGWindowListCreateImageFromArray() Just adds a binding to one small function. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/88) <!-- Reviewable:end -->
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ghost commentedJan 2, 2017
•
edited by larsbergstrom
Includes passing tests.
rustfmttouched a lot of the code, I can fix this if it's an issue.This change is