Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CFDictionary function to get keys and values #89

Merged
merged 1 commit into from Jan 9, 2017

Conversation

@ghost
Copy link

ghost commented Jan 2, 2017

Tests included. No formatting issues this time!


This change is Reviewable

@jdm
Copy link
Member

jdm commented Jan 4, 2017

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

📌 Commit 1c47d8f has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Jan 4, 2017

Testing commit 1c47d8f with merge d5665e9...

bors-servo added a commit that referenced this pull request Jan 4, 2017
Add CFDictionary function to get keys and values

Tests included. No formatting issues this time!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/89)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

💥 Test timed out

@KiChjang
Copy link
Member

KiChjang commented Jan 5, 2017

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 5, 2017

Testing commit 1c47d8f with merge 40fa5f9...

bors-servo added a commit that referenced this pull request Jan 5, 2017
Add CFDictionary function to get keys and values

Tests included. No formatting issues this time!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/89)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 6, 2017

💥 Test timed out

@jdm
Copy link
Member

jdm commented Jan 6, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2017

Testing commit 1c47d8f with merge ab9b2dd...

bors-servo added a commit that referenced this pull request Jan 7, 2017
Add CFDictionary function to get keys and values

Tests included. No formatting issues this time!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/89)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 7, 2017

💥 Test timed out

@jdm jdm closed this Jan 8, 2017
@jdm jdm reopened this Jan 8, 2017
@jdm
Copy link
Member

jdm commented Jan 8, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 8, 2017

Testing commit 1c47d8f with merge 0f614b6...

bors-servo added a commit that referenced this pull request Jan 8, 2017
Add CFDictionary function to get keys and values

Tests included. No formatting issues this time!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/89)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2017

💥 Test timed out

@jdm jdm closed this Jan 9, 2017
@jdm jdm reopened this Jan 9, 2017
@jdm
Copy link
Member

jdm commented Jan 9, 2017

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Jan 9, 2017

Test exempted - status

@bors-servo bors-servo merged commit 1c47d8f into servo:master Jan 9, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details
bors-servo added a commit that referenced this pull request Jan 9, 2017
Add CFDictionary function to get keys and values

Tests included. No formatting issues this time!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/89)
<!-- Reviewable:end -->
@ghost ghost deleted the feature-dictionary-keys-values branch Jan 9, 2017
jdm pushed a commit that referenced this pull request Feb 1, 2018
This follows the servo pattern mentioned in
rust-lang/rust#27303 to replace the zero-sized
structs with an `enum`.
jdm pushed a commit that referenced this pull request Feb 1, 2018
Changes zero-sized structs to an `enum` and removed unused macro use statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.