Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CFPropertyList serialization #90
Merged
+127
−0
Conversation
core-foundation/src/propertylist.rs
Outdated
|
|
||
| pub fn create_with_data(data: CFData, | ||
| options: CFPropertyListMutabilityOptions) | ||
| -> Result<(CFType, CFPropertyListFormat), CFError> { |
This comment has been minimized.
This comment has been minimized.
ghost
Jan 3, 2017
•
Author
I'm not sure that using CFType here is appropriate, especially without an easy way to downcast it to a concrete type. Other parts of the API use *const c_void for these generic types instead.
This comment has been minimized.
This comment has been minimized.
ghost
Jan 4, 2017
Author
I've now converted this to use *const c_void, keeping it consistent with other parts of the API.
|
Looks good! |
core-foundation/src/propertylist.rs
Outdated
| data.as_concrete_TypeRef(), | ||
| options, | ||
| &mut format as *mut CFPropertyListFormat, | ||
| &mut error as *mut CFErrorRef); |
This comment has been minimized.
This comment has been minimized.
core-foundation/src/propertylist.rs
Outdated
| property_list_ref, | ||
| format, | ||
| 0, | ||
| &mut error as *mut CFErrorRef); |
This comment has been minimized.
This comment has been minimized.
|
Unnecessary casts removed. Thanks for the reviews! |
|
@bors-servo: r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 5, 2017
Add CFPropertyList serialization Tests included. Reopened from #88 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-foundation-rs/90) <!-- Reviewable:end -->
ghost
deleted the
jdm
pushed a commit
that referenced
this pull request
Feb 1, 2018
Remove warnings for zero-sized structs This change removes a bunch of warnings from the crate. The only remaining warnings are due to the bitflags macro usage. This will help fix servo/core-text-rs#62 when it upgrades to `core-graphics = 0.9`. @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/90) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ghost commentedJan 2, 2017
•
edited by larsbergstrom
Tests included. Reopened from #88
This change is