Skip to content

/ core-graphics-rs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite all the bindings with the new CF bindings #58

Closed
wants to merge 1 commit into from
Closed

Rewrite all the bindings with the new CF bindings #58

wants to merge 1 commit into from
+349 −619

Conversation

@nox
Copy link
Member

nox commented Oct 13, 2016 •
edited by larsbergstrom

This is a work in progress.

This change is Reviewable
@nox
Rewrite all the bindings with the new CF bindings
Loading status checks…
265cd2c 
This is a work in progress.
@nox
Copy link
Member Author

nox commented Oct 13, 2016

I removed the dependency on Serde for now because I'm not sure it should live here.

This PR demonstrates the usefulness of CFMut, which guarantees for the &mut methods on CGContext that we have unique ownership of the drawing context.
@nox
Copy link
Member Author

nox commented Oct 13, 2016

I also removed the evil private module because it doesn't seem used by anyone.
@bors-servo
Copy link
Contributor

bors-servo commented Oct 29, 2016

☔ The latest upstream changes (presumably #60) made this pull request unmergeable. Please resolve the merge conflicts.
@bors-servo bors-servo mentioned this pull request Feb 1, 2018
Open
@jdm
Copy link
Member

jdm commented Feb 1, 2018

Closing as part of the migration.
@jdm jdm closed this Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @bors-servo @jdm
You can’t perform that action at this time.