Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd CGImage support #79
Merged
Conversation
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 4, 2017
Add CGImage support <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/79) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 24, 2017
Introduces CGWindowList API for window capturing and improves `CGImage` and `CGContext` Initially I just wanted to rewrite #52 as it seems that the author is not interested in changing his pull request. So I just implemented `CGImage` bindings, but today another pull request has been merged (#79) which does exactly the same. This pull request still improves some things in regards to `CGImage`, the most important ones are: * Now `CGImage` uses `CGImageRelease` instead of `CFRelease` (it's a much safer to use `CGImageRelease` here, as it does not crash if you pass a `NULL` image reference to it). * Now you can retrieve bytes from `CGImage` (uses data provider and copies the bytes from it). Also several improvements in `CGContext`: * Added a function `create_image()`, which allows you to create an image out of existing `CGContext`. * Now it is possible to specify a data pointer passed as a first parameter to the `CGBitmapContextCreate()` upon `CGContext` creation -- very important thing when you deal with images as it allows you to specify your own buffer instead of allocating and copying an additional one from the context (tested it on my machine, it gave me 18.46% of performance boost). And of course this pull requests adds `CGWindowListCreateImage()` and related things, so now window capturing is possible. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/80) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
msanders commentedApr 4, 2017
•
edited by larsbergstrom
This change is