Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a .travis.yml for Homu #16
Closed
Conversation
aneeshusa
force-pushed the
aneeshusa:add-.travis.yml
branch
3 times, most recently
from
da389b6
to
409f0bb
aneeshusa
force-pushed the
aneeshusa:add-.travis.yml
branch
2 times, most recently
from
5023e33
to
5fc456a
Currently, we use the W3C's "Nu HTML Checker" (https://github.com/validator/validator) via a Python package, https://github.com/svenkreiss/html5validator, although the actual checker is written in Java 8. Make sure to pin the version as well.
|
r? @jdm (Homu is enabled and should listen to the regular reviewing commands.) |
|
@bors-servo: r+ |
bors-servo
added a commit
to servo/saltfs
that referenced
this pull request
Jan 22, 2017
Quote repo names to ensure valid TOML Otherwise repos like `download.servo.org` which contain dots in their name are not parsed correctly; using quotes ensures the repo name is parsed as a single string. Discovered while trying to merge servo/download.servo.org#16. I have little TOML experience, so I'm not sure if this actually works or will break our `cfg.toml` entirely. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/580) <!-- Reviewable:end -->
|
@bors-servo: r+ It appears that the master had not had salt run since #580. The string |
|
Seems like this still isn't working right. |
|
@bors-servo ping |
|
@bors-servo: r+ |
|
Cherry-picked and landed by hand because first commit of .travis.yml is apparently kind of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedJan 22, 2017
Currently, we use the W3C's "Nu HTML Checker"
(https://github.com/validator/validator) via a Python package,
https://github.com/svenkreiss/html5validator,
although the actual checker is written in Java 8.