Skip to content

/ download.servo.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display checksums on download page #62

Merged
merged 2 commits into from May 16, 2020
Merged

Display checksums on download page #62

merged 2 commits into from May 16, 2020
+36 −18

Conversation

@camelid
Copy link
Contributor

camelid commented May 14, 2020

Let me know if you figure out a better way to position the logo or the checksum! This was the best I came up with.

Fixes #14.
@camelid
Display checksums on download page
Loading status checks…
c57a928
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020

r? @jdm
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020 •
edited

Does this fix #11 too? Perhaps we should show the date that the binary was uploaded.
@jdm
jdm reviewed May 14, 2020
View changes
index.html Outdated Show resolved Hide resolved
@atouchet
Copy link
Contributor

atouchet commented May 14, 2020

Perhaps we should show the date that the binary was uploaded.

Yes, that would be nice to have.
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020

I agree, but the only way I can think of doing that is uploading an additional file with mach called servo-latest-date-linux.txt or something like that which doesn't seem very clean. Plus, it would be hard to display on the download page.

If you come up with a better idea for it, by all means let me know!
@camelid
Improve checksum placement
Loading status checks…
6799bd6 
Also cleaned up some of the other HTML.
@camelid
Copy link
Contributor Author

camelid commented May 14, 2020 •
edited

It moved the download buttons a tiny bit to the right, but it's not too bad.
@camelid
Copy link
Contributor Author

camelid commented May 15, 2020 •
edited

If you come up with a better idea for it, by all means let me know!

@jdm suggests using AJAX and JS to parse an S3 XML metadata file. From Matrix:

the page could make a bunch of XHRs to URLs like http://servo-builds.s3.amazonaws.com/?list-type=2&prefix=nightly/uwp/servo-latest.zip and parse the XML
@camelid camelid requested a review from jdm May 15, 2020
@jdm
Copy link
Member

jdm commented May 16, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

📌 Commit 6799bd6 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

⌛ Testing commit 6799bd6 with merge ead4a0e...
@bors-servo
Copy link
Contributor

bors-servo commented May 16, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing ead4a0e to master...
@bors-servo bors-servo merged commit ead4a0e into servo:master May 16, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@camelid
Copy link
Contributor Author

camelid commented May 16, 2020

Thanks! :)
@camelid camelid deleted the camelid:show-checksums branch May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add checksums for downloads
5 participants
@camelid @atouchet @jdm @bors-servo @highfive
You can’t perform that action at this time.