Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #65

Merged
merged 3 commits into from Jun 20, 2020
Merged

Cleanup #65

merged 3 commits into from Jun 20, 2020

Conversation

@camelid
Copy link
Contributor

camelid commented Jun 19, 2020

Clean up some HTML and shorten the download button text.

r? @jdm

<a class="btn btn-primary btn-large" id="button-windows-exe" role="button"
href="nightly/windows-msvc/servo-latest.exe">Windows Build Installer (64-bit)</a><br>
href="nightly/windows-msvc/servo-latest.exe">Windows EXE (x64)</a><br>

<a class="btn btn-primary btn-large" id="button-windows-zip" role="button"
href="nightly/windows-msvc/servo-latest.zip">Windows Build (64-bit)</a><br>
href="nightly/windows-msvc/servo-latest.zip">Windows ZIP (x64)</a><br>

<a class="btn btn-primary btn-large" id="button-uwp" role="button"
href="nightly/uwp/servo-latest.zip">UWP Build</a><br>
href="nightly/uwp/servo-latest.zip">UWP (arm64/x64)</a><br>

<a class="btn btn-primary btn-large" id="button-macos" role="button"
href="nightly/mac/servo-latest.dmg">macOS Build</a><br>
href="nightly/mac/servo-latest.dmg">macOS</a><br>

<a class="btn btn-primary btn-large" id="button-linux" role="button"
href="nightly/linux/servo-latest.tar.gz">Linux Build (64-bit)</a><br>
href="nightly/linux/servo-latest.tar.gz">Linux (x64)</a><br>
Comment on lines 49 to +62

This comment has been minimized.

@camelid

camelid Jun 19, 2020

Author Contributor

What do you think of the text for the download buttons? I was tempted to put "macOS (x64)" for consistency, but I think 32-bit Macs barely exist these days.

This comment has been minimized.

@jdm

jdm Jun 20, 2020

Member

This seems fine.

@jdm jdm merged commit 396552f into servo:master Jun 20, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@camelid camelid deleted the camelid:cleanup branch Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.