Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing euclid_macros #345

Closed
RazrFalcon opened this issue Jun 12, 2019 · 4 comments

Comments

@RazrFalcon
Copy link

commented Jun 12, 2019

I understand that EuclidMatrix is a useful derive, but it hurts compilation time enormously:

21.14s syn
 8.56s euclid_macros
 5.19s proc_macro2
 2.08s num_traits
 1.54s quote
 1.50s euclid
 1.48s autocfg
 0.12s unicode_xid

3.5s (euclid + num_traits) vs 46sec (current)

PS: I have no idea what EuclidMatrix does.

@kvark

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

We should just make this dependency optional, disabled by default

A brief look at it suggests that this is required as a part of euclid implementation...

@nical

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

I agree that we pay too high a price in compile times just for the sake of having less code to implement a bunch of traits of the euclid types. I'll look into removing it.

@nical

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2019

Fixed in #346

@nical nical closed this Jul 2, 2019

@RazrFalcon

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

Thanks!

2.07s num_traits
1.46s euclid
1.44s autocfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.