Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated matrix2d #10

Merged
merged 3 commits into from Jun 11, 2013
Merged

Updated matrix2d #10

merged 3 commits into from Jun 11, 2013

Conversation

@eschweic
Copy link
Contributor

eschweic commented Jun 10, 2013

Added some functionality to matrix2d.
eschweic
Added more functionality to matrix2d.
0b8ba61
@metajack

This comment has been minimized.

Sign in to view
Copy link

metajack commented on 0b8ba61 Jun 10, 2013

r-

Why create a second constructor instead of using Matrix2D::new()? Old code uses the Type() style, but new code should use ``Type::new()`.

This comment has been minimized.

Sign in to view
Copy link
Owner

eschweic replied Jun 11, 2013

Whoops, I was copying code from the other matrix and hadn't noticed the new() implementation already here. I'll fix this tomorrow.
eschweic added 2 commits Jun 11, 2013
eschweic
Remove redundant constructor in Matrix2D.
95ed255
eschweic
Remove redundant constructor in Matrix2D.
761fff8
pcwalton added a commit that referenced this pull request Jun 11, 2013
@pcwalton
Merge pull request #10 from eschweic/master
efba52c 
Updated matrix2d
@pcwalton pcwalton merged commit efba52c into servo:master Jun 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@eschweic @metajack @pcwalton
You can’t perform that action at this time.