Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for min and max methods on points (Issue #91) #108
Conversation
Add some missing tests and modularise tests (better output). Use assert_eq consistently.
absoludity
force-pushed the
absoludity:scalar-mul-issue-91
branch
from
ceed6e0
to
84150a9
|
r? @glennw |
|
Apologies, I missed this PR. Will take a look at it when I can. |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 24, 2015
Add support for min and max methods on points (Issue #91) Added support for min and max methods for PointND<T: num_lib::traits::Float> Added tests for scalar multiplication of points, expecting them to fail - but they didn't. Modularised tests so that we can have a test_min for each type, rather than test_min_nd etc. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/108) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
absoludity commentedOct 14, 2015
Added support for min and max methods for PointND<T: num_lib::traits::Float>
Added tests for scalar multiplication of points, expecting them to fail - but they didn't.
Modularised tests so that we can have a test_min for each type, rather than test_min_nd etc.