Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make euclid build on stable rustc #117

Closed
wants to merge 3 commits into from
Closed

Make euclid build on stable rustc #117

wants to merge 3 commits into from

Conversation

@nical
Copy link
Collaborator

nical commented Dec 10, 2015

This PR adds an opt-in cargo feature "rustc_stable" to remove the subset of the library that doesn't build on stable rust.

Review on Reviewable

@KiChjang
Copy link
Member

KiChjang commented Dec 10, 2015

src/side_offsets.rs:13:5: 13:8 error: unresolved import `num::Zero`. Maybe a missing `extern crate num`? [E0432]

src/side_offsets.rs:13 use num::Zero;

                           ^~~

src/side_offsets.rs:13:5: 13:8 help: run `rustc --explain E0432` to see a detailed explanation

error: aborting due to previous error

Build failed, waiting for other jobs to finish...

src/side_offsets.rs:13:5: 13:8 error: unresolved import `num::Zero`. Maybe a missing `extern crate num`? [E0432]

src/side_offsets.rs:13 use num::Zero;

                           ^~~

src/side_offsets.rs:13:5: 13:8 help: run `rustc --explain E0432` to see a detailed explanation

error: aborting due to previous error

Could not compile `euclid`.
@nical
Copy link
Collaborator Author

nical commented Dec 10, 2015

I'm installing multirust and will figure out the build failures on nightly (they are in the part that's stripped out when opting into stable). But you guys can already see the approach. Let me know if I am going in the wrong direction.

@metajack
Copy link
Contributor

metajack commented Dec 10, 2015

@@ -10,6 +10,7 @@ license = "MIT / Apache-2.0"
[features]
default = []
plugins = ["serde", "serde_macros", "heapsize", "heapsize_plugin"]
rustc_stable = []

This comment has been minimized.

@kaksmet

kaksmet Dec 16, 2015

Other servo dependencies with a cargo feature to make use of nightly rust has their's named "unstable" (e.g. string-cache, tendril and heapsize).
I therefore think "rustc_stable" should have it's meaning inverted and be renamed to "unstable"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.