Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake generic version of Matrix4D (issue #125) #126
Conversation
|
|
|
r? @glennw |
|
|
|
Apologies I haven't got to this yet - will review tomorrow. |
|
@peterjoel This looks good to me, just needs a rebase. Thanks! |
|
@glennw Done. |
|
@peterjoel GH still thinks this branch is unmergeable? |
|
@glennw Actually done now! I was getting confused between git remotes. You may need to check it over again though, since the merge was a bit annoying - changes were made in the Matrix methods that in the meantime I'd moved to another file. I did the merge manually, based on looking at the commits that touched that file, which appeared to be only two additional #[inline] attributes. |
|
Reviewed 3 of 4 files at r3, 1 of 2 files at r4. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
@bors-servo: r=glennw |
|
|
Make generic version of Matrix4D (issue #125) Matrix2D and the point types are already generic, so there was nothing to do there. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/126) <!-- Reviewable:end -->
|
|
peterjoel commentedFeb 26, 2016
Matrix2D and the point types are already generic, so there was nothing to do there.