Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added is_2d() and new_2d() methods to Matrix4D #134

Merged
merged 2 commits into from Mar 26, 2016
Merged

Added is_2d() and new_2d() methods to Matrix4D #134

merged 2 commits into from Mar 26, 2016
+41 −0

Conversation

@peterjoel
Copy link
Contributor

peterjoel commented Mar 25, 2016

These make sense in Euclid, rather than duplicating in other areas of Servo.

This change is Reviewable
@peterjoel
Added is_2d and new_2d methods
Loading status checks…
396ef8d
@peterjoel peterjoel changed the title Added is_2d() and new_2d() methods Added is_2d() and new_2d() methods to Matrix4D Mar 25, 2016
@frewsxcv
Copy link
Member

frewsxcv commented Mar 25, 2016

For reference where are these used in Servo?
@peterjoel
Copy link
Contributor Author

peterjoel commented Mar 25, 2016

Both used in implementing this https://drafts.fxtf.org/geometry/#dommatrix
(not yet PR'd).

Then there is this: https://github.com/servo/servo/blob/605842f193aedc1151ab38a99c49f693c76e5cf3/components/style/properties.mako.rs#L6490
I am intending to submit another PR which replaces ComputedMatrix with Matrix4D<f32>, as soon as that feature makes it into a proper Euclid release, at which point that block of code can be replaced with if !m.is_2d() {..
@peterjoel
Copy link
Contributor Author

peterjoel commented Mar 25, 2016

@frewsxcv Can you restart the build? It failed on a network connectivity problem.
@frewsxcv
Copy link
Member

frewsxcv commented Mar 25, 2016

Restarted.
@peterjoel
Copy link
Contributor Author

peterjoel commented Mar 25, 2016

@frewsxcv The work in progress that I would like to use this for is:
peterjoel/servo@4ff56ea#diff-1816aa410246f8915a124610d4e5bc3cR3734
peterjoel/servo@4ff56ea#diff-1816aa410246f8915a124610d4e5bc3cR6260
@peterjoel
tests for is_2d and new_2d
Loading status checks…
ca9eb21
@peterjoel peterjoel force-pushed the peterjoel:added_2d branch from d3a4904 to ca9eb21 Mar 26, 2016
@frewsxcv
Copy link
Member

frewsxcv commented Mar 26, 2016

r? @glennw
@frewsxcv
Copy link
Member

frewsxcv commented Mar 26, 2016

Actually, this doesn't necessarily need Glenn, disregard the review ping
@frewsxcv
Copy link
Member

frewsxcv commented Mar 26, 2016

@nox on IRC says this looks good, and it LGTM as well.

@bors-servo r=nox,frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Mar 26, 2016

📌 Commit ca9eb21 has been approved by nox,frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Mar 26, 2016

⌛ Testing commit ca9eb21 with merge 50cb9df...
bors-servo added a commit that referenced this pull request Mar 26, 2016
@bors-servo
Auto merge of #134 - peterjoel:added_2d, r=nox,frewsxcv
Loading status checks…
50cb9df 
Added is_2d() and new_2d() methods to Matrix4D

These make sense in Euclid, rather than duplicating in other areas of Servo.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/134)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 26, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit ca9eb21 into servo:master Mar 26, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox mentioned this pull request Mar 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@peterjoel @frewsxcv @bors-servo
You can’t perform that action at this time.