Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake heapsize and serde support unconditional but without plugins #139
+155
−76
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 10, 2016
Make heapsize and serde support unconditional but without plugins <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/139) <!-- Reviewable:end -->
|
|
|
@bors-servo r=metajack |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 10, 2016
Make heapsize and serde support unconditional but without plugins <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/139) <!-- Reviewable:end -->
|
|
|
@bors-servo r=metajack I can't type. |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 10, 2016
Make heapsize and serde support unconditional but without plugins <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/139) <!-- Reviewable:end -->
|
|
dbrgn
commented
Jun 22, 2017
|
Sorry to wake up this thread, but may I ask what the reasoning was for including heapsize as a non-optional feature? If I understand the note here correctly, it means that that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedJun 10, 2016
•
edited by larsbergstrom
This change is