Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upclippy run and test for Rect::translate_by_size #142
Merged
+52
−33
Conversation
|
@bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 19, 2016
clippy run and test for Rect::translate_by_size Mostly remove calling `.clone()` on `Copy` types. Refactored `Rect::translate_by_size` to use `Rect::translate`. Add test for `Rect::translate_by_size`. I think it would be best to have `Point2D` implement `From<Size2D>` and have only one generic `Rect::translate`, deprecating `Rect::translate_by_size`. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/142) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
leoyvens commentedJun 19, 2016
•
edited by larsbergstrom
Mostly remove calling
.clone()onCopytypes. RefactoredRect::translate_by_sizeto useRect::translate. Add test forRect::translate_by_size. I think it would be best to havePoint2DimplementFrom<Size2D>and have only one genericRect::translate, deprecatingRect::translate_by_size.This change is