Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd serde test for length. Add unit tests for each function in length.rs. #155 #172
Conversation
absoludity
changed the title
absoludity
changed the title
|
One minor comment below. |
src/length.rs
Outdated
| #[test] | ||
| fn test_zero_add() { | ||
| type LengthCm = Length<f32, Cm>; | ||
| let length: LengthCm= Length::new(5.0); |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 3, 2017
Add serde test for length. Add unit tests for each function in length.rs. #155 Also adds unit tests for each function in length.rs. This fixes #155 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/172) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
absoludity commentedDec 18, 2016
•
edited by KiChjang
Also adds unit tests for each function in length.rs.
This fixes #155
This change is