Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename `to_uint` to `to_usize`. #182
Conversation
|
Thank you! |
|
|
Rename `to_uint` to `to_usize`. The naming was a historical artifact and since the types involved as `usize`, the name can match. Fixes #180. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/182) <!-- Reviewable:end -->
|
|
|
Ugh, this is not related to PR:
|
|
@bors-servo retry |
Rename `to_uint` to `to_usize`. The naming was a historical artifact and since the types involved as `usize`, the name can match. Fixes #180. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/182) <!-- Reviewable:end -->
|
|
This looks like a breaking change to me. This is a public method, and this change breaks crates like servo-glutin that call the method by its old name. Filed #187. |
|
i think @kvark meant "Note:", but that's why one shouldn't merge and then forget about what was merged, and we should release often, given we don't maintain a changelog. |
|
Yep, I meant |
waywardmonkeys commentedMar 24, 2017
•
edited by larsbergstrom
The naming was a historical artifact and since the types involved
as
usize, the name can match.Fixes #180.
This change is