Rename to_uint to to_usize.
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming was a historical artifact and since the types involved as `usize`, the name can match. Fixes servo#180.
|
Thank you! |
|
📌 Commit 26fb2e6 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 24, 2017
Rename `to_uint` to `to_usize`. The naming was a historical artifact and since the types involved as `usize`, the name can match. Fixes #180. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/182) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
Ugh, this is not related to PR:
|
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Mar 24, 2017
Rename `to_uint` to `to_usize`. The naming was a historical artifact and since the types involved as `usize`, the name can match. Fixes #180. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/182) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
This looks like a breaking change to me. This is a public method, and this change breaks crates like servo-glutin that call the method by its old name. Filed #187. |
|
i think @kvark meant "Note:", but that's why one shouldn't merge and then forget about what was merged, and we should release often, given we don't maintain a changelog. |
|
Yep, I meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming was a historical artifact and since the types involved
as
usize, the name can match.Fixes #180.
This change is