Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTyped rects with negative sizes should return as an empty rect #183
Conversation
|
It's a feature that is small but needs a somewhat broader consensus (RFC?). |
|
It seems that if #177 is implemented this won't be an issue, because negative lengths won't be possible. |
|
@mrobinson but we'd still have negative rectangles |
|
So do we try for an RFC? @kvark I have some issues in WR dealing with empty rects right now. I can work around them if that's ok and clean them up once this is fixed? |
|
@changm I don't feel myself in a position to make this decision for |
|
There hasn't been activity for a while, so closing this for now. We can open a new PR/issue if we still want to use check for negative rects, although doing so would require carefully checking WebRender/Servo's code to make sure it doesn't introduce subtle breakage. |
changm commentedApr 13, 2017
•
edited by larsbergstrom
This change is