Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed rects with negative sizes should return as an empty rect #183

Closed
wants to merge 1 commit into from

Conversation

@changm
Copy link

changm commented Apr 13, 2017

This change is Reviewable

@changm changm requested a review from mrobinson Apr 13, 2017
@kvark
Copy link
Member

kvark commented Apr 13, 2017

It's a feature that is small but needs a somewhat broader consensus (RFC?).
Are there any users that rely on negative rectangles?

@mrobinson
Copy link
Member

mrobinson commented Apr 13, 2017

It seems that if #177 is implemented this won't be an issue, because negative lengths won't be possible.

@kvark
Copy link
Member

kvark commented Apr 13, 2017

@mrobinson but we'd still have negative rectangles

@changm changm force-pushed the changm:empty branch from b07910d to de30d02 Apr 13, 2017
@changm
Copy link
Author

changm commented Apr 13, 2017

So do we try for an RFC?

@kvark I have some issues in WR dealing with empty rects right now. I can work around them if that's ok and clean them up once this is fixed?

@kvark
Copy link
Member

kvark commented Apr 13, 2017

@changm I don't feel myself in a position to make this decision for euclid, so unless someone steps in and approve it, I suggest working around it without modifying euclid.

@nical
Copy link
Collaborator

nical commented Jun 7, 2018

There hasn't been activity for a while, so closing this for now. We can open a new PR/issue if we still want to use check for negative rects, although doing so would require carefully checking WebRender/Servo's code to make sure it doesn't introduce subtle breakage.

@nical nical closed this Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.