Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate heapsize dependency. #193
Conversation
|
Is it an implementation detail? I'd assume that since the public types implement |
|
No aspect of the HeapSizeOf trait changed, and this crate does not reexport the pieces of heapsize that did change. |
The trait itself is technically different. Supposing the user code has that: extern crate euclid; //version 0.12.0
extern crate heapsize; //version 0.3
use heapsize::HeapSizeOf;
fn foo<T, U>(length: euclid::Length<T, U>) -> usize {
length.heap_size_of_children()
}This works. Now the user does |
|
I am convinced. |
|
Thanks! Do you mind squashing it? |
|
@bors-servo: r=kvark |
|
|
Update heapsize dependency. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/193) <!-- Reviewable:end -->
|
|
jdm commentedMay 18, 2017
•
edited by larsbergstrom
This change is