Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heapsize dependency. #193

Merged
merged 1 commit into from May 18, 2017
Merged

Update heapsize dependency. #193

merged 1 commit into from May 18, 2017

Conversation

@jdm
Copy link
Member

jdm commented May 18, 2017

This change is Reviewable

@kvark
Copy link
Member

kvark commented May 18, 2017

Is it an implementation detail? I'd assume that since the public types implement heapsize trait and they are visible, then the dependency is also public-visible, and thus should bump the minor package version.

@jdm
Copy link
Member Author

jdm commented May 18, 2017

No aspect of the HeapSizeOf trait changed, and this crate does not reexport the pieces of heapsize that did change.

@kvark
Copy link
Member

kvark commented May 18, 2017

@jdm

No aspect of the HeapSizeOf trait changed

The trait itself is technically different. Supposing the user code has that:

extern crate euclid; //version 0.12.0
extern crate heapsize; //version 0.3
use heapsize::HeapSizeOf;

fn foo<T, U>(length: euclid::Length<T, U>) -> usize {
  length.heap_size_of_children()
}

This works. Now the user does cargo update -p euclid, gets version 0.12.1, and suddenly their code breaks because the imported HeapSizeOf doesn't match euclid's HeapSizeOf.

@jdm
Copy link
Member Author

jdm commented May 18, 2017

I am convinced.

@kvark
Copy link
Member

kvark commented May 18, 2017

Thanks! Do you mind squashing it?
r=me

@jdm jdm force-pushed the jdm-patch-1 branch from e0ff3b8 to 72bc87c May 18, 2017
@jdm
Copy link
Member Author

jdm commented May 18, 2017

@bors-servo: r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

📌 Commit 72bc87c has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

Testing commit 72bc87c with merge 16ee6fc...

bors-servo added a commit that referenced this pull request May 18, 2017
Update heapsize dependency.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/193)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 16ee6fc to master...

@bors-servo bors-servo merged commit 72bc87c into master May 18, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@kvark kvark deleted the jdm-patch-1 branch May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.