Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRe-export all euclid types and hide the module hierarchy. #199
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 29, 2017
Re-export all euclid types and hide the module hierarchy. There was a mix between things that were reexported in lib.rs (most types) all of which were also accessible through their modules (you get to choose between euclid::Bar and euclid::foo::Bar), and a few that were public but only accessible in sub modules. Let's clean this up and export everything public in lib.rs. A nice side effect of this is that it makes it possible to export the function euclid::rect which was otherwise clashing with the module euclid::rect. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/199) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedMay 29, 2017
•
edited by larsbergstrom
There was a mix between things that were reexported in lib.rs (most types) all of which were also accessible through their modules (you get to choose between euclid::Bar and euclid::foo::Bar), and a few that were public but only accessible in sub modules.
Let's clean this up and export everything public in lib.rs. A nice side effect of this is that it makes it possible to export the function euclid::rect which was otherwise clashing with the module euclid::rect.
This change is