Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix terrible mistake in TypedVector3D::to_point #204
Merged
+28
−2
Conversation
|
r? @nox |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 2, 2017
Fix terrible mistake in TypedVector3D::to_point <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/204) <!-- Reviewable:end -->
|
|
| @@ -430,7 +430,7 @@ impl<T: Copy, U> TypedPoint3D<T, U> { | |||
| /// Equivalent to substracting the origin to this point. | |||
| #[inline] | |||
| pub fn to_vector(&self) -> TypedVector3D<T, U> { | |||
| vec3(self.x, self.y, self.y) | |||
| vec3(self.x, self.y, self.z) | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJun 2, 2017
•
edited by larsbergstrom
This change is