Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd extend method and get euclid to build with rustc 1.15. #208
Conversation
|
r? @kvark |
| @@ -325,7 +331,7 @@ where T: Copy + One + Add<Output=T> + Sub<Output=T> + Mul<Output=T> { | |||
| } | |||
| } | |||
|
|
|||
| impl<T: Copy+ApproxEq<T>, U> ApproxEq<Self> for TypedPoint2D<T, U> { | |||
| impl<T: Copy+ApproxEq<T>, U> ApproxEq<TypedPoint2D<T, U>> for TypedPoint2D<T, U> { | |||
This comment has been minimized.
This comment has been minimized.
kvark
Jun 8, 2017
Member
argh... I wonder if/when traits like this would be able to be defined with Self as default generic parameter
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 8, 2017
Add extend method and get euclid to build with rustc 1.15. WebRender's CI runs rustc 1.15 to match gecko's, and in euclid 14.0 we introduced a usage of self that apparently was not allowed with this version of the compiler. This commit also adds the extend method suggested in the review of the euclid bump in WebRender. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/208) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJun 8, 2017
•
edited by mbrubeck
WebRender's CI runs rustc 1.15 to match gecko's, and in euclid 14.0 we introduced a usage of self that apparently was not allowed with this version of the compiler.
This commit also adds the extend method suggested in the review of the euclid bump in WebRender.
This change is