Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upefficacious `#[must_use]` methods for nightly, fix warnings #225
+39
−40
Conversation
137660d annotated many methods with `#[must_use]`, but despite not being rejected by the compiler, this is actually a no-op (as of Rust 1.20). `#[must_use]` for functions is now available on nightly Rust (since rust-lang/rust@3645b06), under a feature-gate (since rust-lang/rust@8492ad2 and 35c44941), with a warning if `#[must_use]` appears on a function or method without the feature being enabled—a warning that regrettably added a lot of noise to Euclid's build, as reported in rust-lang/rust#44213. But with judicious use of `cfg_attr`, Euclid can make use of this functionality if our "unstable" feature is enabled, and shut up the warnings in any case.
|
@bors-servo r+ Thanks for your contribution. |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 13, 2017
efficacious `#[must_use]` methods for nightly, fix warnings 137660d annotated many methods with `#[must_use]`, but despite not being rejected by the compiler, this is actually a no-op (as of Rust 1.20). `#[must_use]` for functions is now available on nightly Rust (since rust-lang/rust@3645b06), under a feature-gate (since rust-lang/rust@8492ad2 and 35c44941), with a warning if `#[must_use]` appears on a function or method without the feature being enabled—a warning that regrettably added a lot of noise to Euclid's build, as reported in rust-lang/rust#44213. But with judicious use of [`cfg_attr`](https://doc.rust-lang.org/1.19.0/book/first-edition/conditional-compilation.html#cfg_attr), Euclid can make use of this functionality if our "unstable" feature is enabled, and shut up the warnings in any case.  (SHA in the screenshot doesn't match because I had to amend the commit message) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/225) <!-- Reviewable:end -->
|
|
This was referenced Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zackmdavis commentedSep 1, 2017
•
edited by nox
137660d annotated many methods with
#[must_use], but despite notbeing rejected by the compiler, this is actually a no-op (as of Rust
1.20).
#[must_use]for functions is now available on nightlyRust (since rust-lang/rust@3645b06), under a feature-gate (since
rust-lang/rust@8492ad2 and 35c44941), with a warning if
#[must_use]appears on a function or method without the feature being enabled—a
warning that regrettably added a lot of noise to Euclid's build, as
reported in rust-lang/rust#44213. But with judicious use of
cfg_attr,Euclid can make use of this functionality if our "unstable" feature is
enabled, and shut up the warnings in any case.
(SHA in the screenshot doesn't match because I had to amend the commit message)
This change is