Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efficacious `#[must_use]` methods for nightly, fix warnings #225

Merged
merged 1 commit into from Sep 13, 2017

Commits on Sep 1, 2017

  1. efficacious `#[must_use]` methods for nightly, fix warnings

    137660d annotated many methods with `#[must_use]`, but despite not
    being rejected by the compiler, this is actually a no-op (as of Rust
    1.20). `#[must_use]` for functions is now available on nightly
    Rust (since rust-lang/rust@3645b06), under a feature-gate (since
    rust-lang/rust@8492ad2 and 35c44941), with a warning if `#[must_use]`
    appears on a function or method without the feature being enabled—a
    warning that regrettably added a lot of noise to Euclid's build, as
    reported in rust-lang/rust#44213. But with judicious use of `cfg_attr`,
    Euclid can make use of this functionality if our "unstable" feature is
    enabled, and shut up the warnings in any case.
    zackmdavis committed Sep 1, 2017
You can’t perform that action at this time.