Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd cast function for transform2d/3d. #230
Merged
Conversation
|
r? @nical |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 16, 2017
Add cast function for transform2d/3d. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/230) <!-- Reviewable:end -->
|
|
| impl<T0: NumCast + Copy, Src, Dst> TypedTransform3D<T0, Src, Dst> { | ||
| /// Cast from one numeric representation to another, preserving the units. | ||
| pub fn cast<T1: NumCast + Copy>(&self) -> Option<TypedTransform3D<T1, Src, Dst>> { | ||
| match (NumCast::from(self.m11), NumCast::from(self.m12), |
This comment has been minimized.
This comment has been minimized.
kvark
Oct 16, 2017
Member
I wonder if it would be easier somehow to extract the vectors from a matrix, cast them (it's already there), and compose a new matrix from vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mephisto41 commentedOct 16, 2017
•
edited by larsbergstrom
This change is