Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upScalar multiplication and division for Length #240
Merged
Conversation
Implement Mul<T>, Div<T>, MulAssign<T> and DivAssign<T> for Length<T, U> which multiply or divide the value but preserve the unit.
|
Looks good, thanks! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 4, 2017
Scalar multiplication and division for Length Implement `Mul<T>`, `Div<T>`, `MulAssign<T>` and `DivAssign<T>` for `Length<T, U>` which multiply or divide the value but preserve the unit. Tests for all four new implementations are included. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/240) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Noughmad commentedDec 4, 2017
•
edited by larsbergstrom
Implement
Mul<T>,Div<T>,MulAssign<T>andDivAssign<T>forLength<T, U>which multiply or divide the value but preserve the unit.
Tests for all four new implementations are included.
This change is