Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRename ScaleFactor into TypedScale. #242
Merged
Conversation
|
@kvark r? |
|
consistency ftw! |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 7, 2017
Rename ScaleFactor int TypedScale. @SimonSapin is about to do a breaking change in euclid (and corresponding bumps in the servo ecosystem), so I'd like to sneak in a few breaking changes that I hadn't bothered to do because bumping euclid is tiresome. This one might not actually be a breaking change because I added a ScaleFactor alias with a deprecated annotation, but it's hard to know for sure. The idea is to rename ScaleFactor into TypedScale and make it's api more in line with the other transformation types (TypedTransform2D/3D, TypedRotation, etc.). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/242) <!-- Reviewable:end -->
|
|
nical
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedDec 7, 2017
•
edited by larsbergstrom
@SimonSapin is about to do a breaking change in euclid (and corresponding bumps in the servo ecosystem), so I'd like to sneak in a few breaking changes that I hadn't bothered to do because bumping euclid is tiresome.
This one might not actually be a breaking change because I added a ScaleFactor alias with a deprecated annotation, but it's hard to know for sure.
The idea is to rename ScaleFactor into TypedScale and make it's api more in line with the other transformation types (TypedTransform2D/3D, TypedRotation, etc.).
This change is