Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual fixes #249

Merged
merged 3 commits into from Dec 14, 2017
Merged

Textual fixes #249

merged 3 commits into from Dec 14, 2017

Conversation

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Dec 14, 2017

This change is Reviewable

@kvark
kvark approved these changes Dec 14, 2017
Copy link
Member

kvark left a comment

Looks good, thanks!
leaving for @nical to decide if it needs squashing

@nical
Copy link
Collaborator

nical commented Dec 14, 2017

Nice, thanks a lot! The commits look self contained, no need to squash them (as far as I am concerned).

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2017

📌 Commit 10e4708 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2017

Testing commit 10e4708 with merge 7188a5c...

bors-servo added a commit that referenced this pull request Dec 14, 2017
Textual fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/249)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2017

☀️ Test successful - status-travis
Approved by: nical
Pushing 7188a5c to master...

@bors-servo bors-servo merged commit 10e4708 into servo:master Dec 14, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:textual-fixes branch Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.