Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fixes #250

Merged
merged 1 commit into from Dec 16, 2017
Merged

Clippy fixes #250

merged 1 commit into from Dec 16, 2017

Conversation

@waywardmonkeys
Copy link
Contributor

waywardmonkeys commented Dec 14, 2017

This change is Reviewable

@kvark
kvark approved these changes Dec 14, 2017
Copy link
Member

kvark left a comment

Nice!
Could you squash please?
Also, would be great to hook up Clippy to CI

@waywardmonkeys waywardmonkeys force-pushed the waywardmonkeys:clippy-fixes branch from e15c23b to 6c54656 Dec 16, 2017
@waywardmonkeys
Copy link
Contributor Author

waywardmonkeys commented Dec 16, 2017

Squashed. This doesn't fix all of the clippy warnings, btw.

@KiChjang
Copy link
Member

KiChjang commented Dec 16, 2017

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2017

📌 Commit 6c54656 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2017

Testing commit 6c54656 with merge b4a2e42...

bors-servo added a commit that referenced this pull request Dec 16, 2017
Clippy fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/250)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing b4a2e42 to master...

@bors-servo bors-servo merged commit 6c54656 into servo:master Dec 16, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@waywardmonkeys waywardmonkeys deleted the waywardmonkeys:clippy-fixes branch Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.