Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd PartialOrd support to all structs #252
Conversation
|
This ordering is arbitrary and has no meaningful relationship to geometry. If all you need is determinism in the iteration order of a set that’s fine, but it seems wrong to me to implement “the” ordering trait for this. Other trait impls like Perhaps instead of |
|
Looks like a duplicate of #234, where the disposition appears to be: |
TyOverby commentedDec 17, 2017
•
edited by larsbergstrom
Lack of PartialOrd support was my only issue when porting some of my code over to Euclid.
It's especially useful to preserve determinism after producing shapes in a non-deterministic manner.
Example:
Not the distinct lack of tests. I wanted to run this by folks here before spending too much time on writing tests.
This change is