Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary approxeq trait bounds. #253
Merged
+3
−24
Conversation
|
I had to remove two tests that check that the number 10.0 is formatted as "10" when printed, since this behavior apparently changed in rustc nightly. Honestly, I don't think these tests are very useful anyway. |
|
LGTM |
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 30, 2017
Remove unnecessary approxeq trait bounds. I might be able to remove the ApproxEq trait entirely or implement it in terms of the Float trait that is already implemented by implementers of ApproxEq, but in the mean time this already makes life easier for downstream crates that try to be generic over floats without haing to depend on many traits. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/253) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedDec 30, 2017
•
edited by larsbergstrom
I might be able to remove the ApproxEq trait entirely or implement it in terms of the Float trait that is already implemented by implementers of ApproxEq, but in the mean time this already makes life easier for downstream crates that try to be generic over floats without haing to depend on many traits.
This change is