Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBetter document Rect::from_points. #255
Merged
Conversation
Merged
|
@bors-servo r=kvark |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 1, 2018
Better document Rect::from_points. Fixes #245 and #238. It would be nice to actually fix this but I need to think about it some more (or wait for specialization). cc @rsaarelm @kvark <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/255) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedDec 31, 2017
•
edited by larsbergstrom
Fixes #245 and #238.
It would be nice to actually fix this but I need to think about it some more (or wait for specialization).
cc @rsaarelm @kvark
This change is