Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd inner_rect and outer_rect methods to Rect #260
Merged
Conversation
src/rect.rs
Outdated
| self.size.height - offsets.vertical() | ||
| ) | ||
| ); | ||
| assert!(rect.size.width >= Zero::zero()); |
This comment has been minimized.
This comment has been minimized.
|
Changed to debug_assert! |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 14, 2018
Add inner_rect and outer_rect methods to Rect Closes #258 cc @nical Note: The `outer_rect` method is similar to the existing `inflate` method but more powerful. If `SideOffsets2D` hat a constructor taking two offsets one for each direction the `inflate` method could be removed I guess. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/260) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedJan 14, 2018
•
edited by larsbergstrom
Closes #258
cc @nical
Note: The
outer_rectmethod is similar to the existinginflatemethod but more powerful. IfSideOffsets2Dhat a constructor taking two offsets one for each direction theinflatemethod could be removed I guess.This change is