Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun rustfmt on entire codebase #261
Conversation
| m41: T, | ||
| m42: T, | ||
| m43: T, | ||
| m44: T, |
This comment has been minimized.
This comment has been minimized.
nical
Jan 14, 2018
Collaborator
Having the matrix members visually laid out helps me a lot (I can never remember m12 vs m21 etc.). That's the only thing that I would like to see formatted manually, but other than that the code looks a lot nicer, thanks!
Could you leave transform2d.rs and transform3d.rs out of this PR? I can go through these two files and selectively reformat them. Until we commit to automated reformatting or something that would really force us to lose the formatting of the parameters, I would prefer to preserve the visual layout of the members/arguments for now.
|
Removed transform3d.rs and transform2d.rs The hand formatted matrices are definitely easier to understand. |
|
Thanks again! @bors-servo r+ |
|
|
Run rustfmt on entire codebase See #181 Code looks good but I have not checked every line. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/261) <!-- Reviewable:end -->
|
|
pyfisch commentedJan 14, 2018
•
edited by larsbergstrom
See #181
Code looks good but I have not checked every line.
This change is