Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMissing serde impl for Angle, and remove log dependency. #265
Conversation
|
r? @SimonSapin |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 29, 2018
Missing serde impl for Angle, and remove log dependency. The Angle type was missing `Serialize` and `Deserialize` implementations, this PR addresses that. In the process I removed the dependency to the log crate which was only used in one place in a test and wasn't really needed, and bumped euclid's own version from 0.16.3 to 0.16.4. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/265) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nical commentedJan 29, 2018
•
edited by larsbergstrom
The Angle type was missing
SerializeandDeserializeimplementations, this PR addresses that. In the process I removed the dependency to the log crate which was only used in one place in a test and wasn't really needed, and bumped euclid's own version from 0.16.3 to 0.16.4.This change is