Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serde optional #267

Merged
merged 4 commits into from Jan 30, 2018
Merged

Make serde optional #267

merged 4 commits into from Jan 30, 2018

Conversation

@pizzaiter
Copy link
Contributor

pizzaiter commented Jan 29, 2018

Closes #264

This PR makes serde support optional. At the moment it is disabled by default.

I am not very sure about my changes to .travis.yml but it seems to work.


This change is Reviewable

@kvark
kvark approved these changes Jan 30, 2018
.travis.yml Outdated
@@ -3,14 +3,22 @@ language: rust
notifications:
webhooks: http://build.servo.org:54856/travis

rust:
- 1.21.0

This comment has been minimized.

@kvark

kvark Jan 30, 2018

Member

should be 1.23.0 now

@nical
Copy link
Collaborator

nical commented Jan 30, 2018

Thanks for doing this! Since this is a breaking change, could you also bump euclid's version to 0.17.0 (so that I don't forget and break all of servo next time I publish a minor change)?
And as kvark said, now is a good time to use rustc 1.23.0 since it's the version we currently use for gecko and servo's CI.

@kvark
Copy link
Member

kvark commented Jan 30, 2018

@nical I wonder if this would still be considered a breaking change if serde feature is enabled by default.

@nical
Copy link
Collaborator

nical commented Jan 30, 2018

I suppose it would not be a breaking change but disabling default features is a real pain in the lower back, because each crate in the same program depending on euclid would need to separately disable default features (and if euclid one day gets several default feaures I think that you can't specifically disable a default feature, you need to disable them all and reenable the ones you wanted to keep).

So now might be a good time to just go ahead with the various breaking changes that have been withheld to avoid bumping euclid all over servo.

@kvark
Copy link
Member

kvark commented Jan 30, 2018

Yes, sure. I'm all for having it off by default, but in the new version. We can still patch the current one with having it on by default.

@nical
Copy link
Collaborator

nical commented Jan 30, 2018

Sure thing, although unless there are non-breaking changes that we want to make now, since I believe having serde as a default feature isn't super useful, I wouldn't bother with it and just go ahead with a round of euclid bumps in servo.

@pizzaiter
Copy link
Contributor Author

pizzaiter commented Jan 30, 2018

I pushed two new commits bumping the rust version and euclid's version.

@nical
Copy link
Collaborator

nical commented Jan 30, 2018

Great, thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2018

📌 Commit 977e136 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2018

Testing commit 977e136 with merge 7bb2617...

bors-servo added a commit that referenced this pull request Jan 30, 2018
Make serde optional

Closes #264

This PR makes serde support optional. At the moment it is disabled by default.

I am not very sure about my changes to `.travis.yml` but it seems to work.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/267)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2018

☀️ Test successful - status-travis
Approved by: nical
Pushing 7bb2617 to master...

@bors-servo bors-servo merged commit 977e136 into servo:master Jan 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.