Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake serde optional #267
Make serde optional #267
Conversation
| @@ -3,14 +3,22 @@ language: rust | |||
| notifications: | |||
| webhooks: http://build.servo.org:54856/travis | |||
|
|
|||
| rust: | |||
| - 1.21.0 | |||
This comment has been minimized.
This comment has been minimized.
|
Thanks for doing this! Since this is a breaking change, could you also bump euclid's version to 0.17.0 (so that I don't forget and break all of servo next time I publish a minor change)? |
|
@nical I wonder if this would still be considered a breaking change if |
|
I suppose it would not be a breaking change but disabling default features is a real pain in the lower back, because each crate in the same program depending on euclid would need to separately disable default features (and if euclid one day gets several default feaures I think that you can't specifically disable a default feature, you need to disable them all and reenable the ones you wanted to keep). So now might be a good time to just go ahead with the various breaking changes that have been withheld to avoid bumping euclid all over servo. |
|
Yes, sure. I'm all for having it off by default, but in the new version. We can still patch the current one with having it on by default. |
|
Sure thing, although unless there are non-breaking changes that we want to make now, since I believe having serde as a default feature isn't super useful, I wouldn't bother with it and just go ahead with a round of euclid bumps in servo. |
|
I pushed two new commits bumping the rust version and euclid's version. |
|
Great, thanks! @bors-servo r+ |
|
|
Make serde optional Closes #264 This PR makes serde support optional. At the moment it is disabled by default. I am not very sure about my changes to `.travis.yml` but it seems to work. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/267) <!-- Reviewable:end -->
|
|
pizzaiter commentedJan 29, 2018
•
edited by larsbergstrom
Closes #264
This PR makes serde support optional. At the moment it is disabled by default.
I am not very sure about my changes to
.travis.ymlbut it seems to work.This change is