Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate TypedTransform2D docs #272
Merged
Conversation
I think matrix dimensions are typically talked about as <num_row> by <num_col> instead of the opposite <num_col> by <num_row>.
|
You are right. @bors-servo r+ Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 6, 2018
Update TypedTransform2D docs I think matrix dimensions are typically talked about as <num_row> by <num_col> instead of the opposite <num_col> by <num_row>. https://en.wikipedia.org/wiki/Matrix_(mathematics) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/272) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
garyemerson commentedFeb 6, 2018
•
edited by larsbergstrom
I think matrix dimensions are typically talked about as <num_row> by <num_col> instead of the opposite <num_col> by <num_row>.
https://en.wikipedia.org/wiki/Matrix_(mathematics)
This change is