Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement to_u32() #274
Merged
Implement to_u32() #274
+59
−1
Conversation
|
Looks good modulo the version number. Thanks! |
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "euclid" | |||
| version = "0.17.0" | |||
| version = "0.18.0" | |||
This comment has been minimized.
This comment has been minimized.
nical
Feb 26, 2018
Collaborator
This isn't a breaking change, so i'd prefer to make it 0.17.1 instead of 0.18.0.
|
@nical done. |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 27, 2018
Implement to_u32() Fix #237 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/274) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedFeb 26, 2018
•
edited by larsbergstrom
Fix #237
This change is