Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform_point2d_homogeneous #281

Merged
merged 1 commit into from Mar 19, 2018
Merged

Fix transform_point2d_homogeneous #281

merged 1 commit into from Mar 19, 2018
+49 −18

Conversation

@kvark
Copy link
Member

kvark commented Mar 19, 2018 •
edited by larsbergstrom

I made a mistake in transform_point2d_homogeneous that wasn't covered by tests. Now it is.

This change is Reviewable
@kvark
Fix transform_point2d_homogeneous
Loading status checks…
49dedff
@kvark kvark requested a review from nical Mar 19, 2018
@glennw
Copy link
Member

glennw commented Mar 19, 2018

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

📌 Commit 49dedff has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

⌛ Testing commit 49dedff with merge 9ac3e8c...
bors-servo added a commit that referenced this pull request Mar 19, 2018
@bors-servo
Auto merge of #281 - kvark:homogen-fix, r=glennw
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9ac3e8c 
Fix transform_point2d_homogeneous

I made a mistake in `transform_point2d_homogeneous` that wasn't covered by tests. Now it is.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/281)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 19, 2018

☀️ Test successful - status-travis
Approved by: glennw
Pushing 9ac3e8c to master...
@bors-servo bors-servo merged commit 49dedff into servo:master Mar 19, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kvark @glennw @bors-servo
You can’t perform that action at this time.