Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upType safe perspective division #291
Merged
+81
−49
Conversation
|
LGTM. |
|
Alright, I went through the code, cleaned up a bit and added a few more tests. Should be ready now. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 7, 2018
Type safe perspective division Fixes #290 This is not necessarily the final version of the code but just something to support the position, something that allows to get a basic impression on how much ~~noise those unwraps are adding~~ safety those new methods are providing :) Feedback is welcome! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/291) <!-- Reviewable:end -->
|
|
This was referenced Jul 18, 2018
bors-servo
added a commit
to servo/webrender
that referenced
this pull request
Aug 3, 2018
Proper near plane splitting The PR is built on the shoulders of #2913, #2741, servo/euclid#277, servo/euclid#291, servo/plane-split#12, and (last but not the least!) servo/plane-split#15 It uses the new clipping semantics in `plane-split` crate uniformly for both bounding box computation and 3d plane splitting itself, ensuring that no incorrect perspective divisions are performed (and closing quite a few TODO entries). Also adds a small reftest for the latter. Fixes #2272 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2947) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedJun 6, 2018
•
edited by larsbergstrom
Fixes #290
This is not necessarily the final version of the code but just something to support the position, something that allows to get a basic impression on how much
noise those unwraps are addingsafety those new methods are providing :) Feedback is welcome!This change is