Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemt Rect::from_size and From<Size> for Rect. #293

Merged
merged 1 commit into from Jun 7, 2018

Conversation

@nical
Copy link
Collaborator

nical commented Jun 7, 2018

Fixes #288.


This change is Reviewable

@kvark
kvark approved these changes Jun 7, 2018
@@ -103,6 +103,19 @@ impl<T, U> TypedRect<T, U> {
}
}

impl<T, U> TypedRect<T, U>
where
T: Copy + Zero

This comment has been minimized.

@kvark

kvark Jun 7, 2018

Member

I don't think Copy is needed here

This comment has been minimized.

@nical

nical Jun 7, 2018

Author Collaborator

Ah, yes indeed.

This comment has been minimized.

@nical

nical Jun 7, 2018

Author Collaborator

Err, actually, turns out Zero requires Copy.

@kvark
Copy link
Member

kvark commented Jun 7, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2018

📌 Commit 7c1282d has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2018

Testing commit 7c1282d with merge 055f60b...

bors-servo added a commit that referenced this pull request Jun 7, 2018
Implemt Rect::from_size and From<Size> for Rect.

Fixes #288.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/293)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2018

☀️ Test successful - status-travis
Approved by: kvark
Pushing 055f60b to master...

@bors-servo bors-servo merged commit 7c1282d into servo:master Jun 7, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.