Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cast infallible and add try_cast. #294

Merged
merged 1 commit into from Jun 14, 2018
Merged

Make cast infallible and add try_cast. #294

merged 1 commit into from Jun 14, 2018

Conversation

@nical
Copy link
Collaborator

nical commented Jun 7, 2018

Fixes #270.


This change is Reviewable

@kvark
kvark approved these changes Jun 7, 2018
Copy link
Member

kvark left a comment

Now I'm starting to get excited for 0.18 :)

@kvark
Copy link
Member

kvark commented Jun 7, 2018

@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2018

📌 Commit ddb26e1 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 7, 2018

Testing commit ddb26e1 with merge dbab241...

bors-servo added a commit that referenced this pull request Jun 7, 2018
Make cast infallible and add try_cast.

Fixes #270.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/294)
<!-- Reviewable:end -->
@nical nical force-pushed the nical:try-cst branch from ddb26e1 to ee8d415 Jun 7, 2018
@nical
Copy link
Collaborator Author

nical commented Jun 14, 2018

@bors-servo retry

@nical
Copy link
Collaborator Author

nical commented Jun 14, 2018

@bors-servo r=kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

📌 Commit ee8d415 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

Testing commit ee8d415 with merge 766d2e9...

bors-servo added a commit that referenced this pull request Jun 14, 2018
Make cast infallible and add try_cast.

Fixes #270.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/294)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2018

☀️ Test successful - status-travis
Approved by: kvark
Pushing 766d2e9 to master...

@bors-servo bors-servo merged commit ee8d415 into servo:master Jun 14, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.