Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rect::area #309

Merged
merged 1 commit into from Nov 16, 2018
Merged

Add Rect::area #309

merged 1 commit into from Nov 16, 2018

Conversation

@nical
Copy link
Collaborator

nical commented Nov 16, 2018

Just a convenience function that calls into Size2D::area.


This change is Reviewable

@nical
Copy link
Collaborator Author

nical commented Nov 16, 2018

r? anyone

@emilio
emilio approved these changes Nov 16, 2018
@@ -399,6 +399,12 @@ impl<T, U> TypedRect<T, U> {
}
}

impl<T: Copy + Clone + Mul<T, Output = T>, U> TypedRect<T, U> {
pub fn area(&self) -> T {

This comment has been minimized.

@emilio

emilio Nov 16, 2018

Member

Maybe #[inline]? But not a big deal in any case.

This comment has been minimized.

@nical

nical Nov 16, 2018

Author Collaborator

Good point. Done.

@emilio
Copy link
Member

emilio commented Nov 16, 2018

@bors-servo delegate+

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

✌️ @nical can now approve this pull request

@nical nical force-pushed the nical:rect-area branch from 19b95ac to 65e4369 Nov 16, 2018
@nical
Copy link
Collaborator Author

nical commented Nov 16, 2018

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

📌 Commit 65e4369 has been approved by emilio

bors-servo added a commit that referenced this pull request Nov 16, 2018
Add Rect::area

Just a convenience function that calls into `Size2D::area`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/309)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

Testing commit 65e4369 with merge 0b810d5...

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2018

☀️ Test successful - status-travis
Approved by: emilio
Pushing 0b810d5 to master...

@bors-servo bors-servo merged commit 65e4369 into servo:master Nov 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nical nical deleted the nical:rect-area branch Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.