Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the `define_matrix!` macro using a proc macro. #314

Merged
merged 11 commits into from Jan 12, 2019
Merged

Replace the `define_matrix!` macro using a proc macro. #314

merged 11 commits into from Jan 12, 2019
+459 −220

Conversation

@emilio
Copy link
Member

emilio commented Jan 12, 2019 •
edited by larsbergstrom

This will allow cbindgen to parse this without macro expansion, which will allow us to do it much faster, and at build-time.

This change is Reviewable
emilio added 10 commits Jan 11, 2019
@emilio
macros: Add an empty proc macro derive for EuclidMatrix.
872f960
@emilio
macros: Add style_derive's dependencies, and move the crate up a dire…
90f12fd 
…ctory.
@emilio
macros: Scaffold the euclid_matrix derive.
294d43f
@emilio
macros: Derive clone using the new macro instead of the old one.
f8212f0
@emilio
macros: Derive Copy.
bfe23b9
@emilio
macros: Derive serialize / deserialize.
470c683
@emilio
macros: Derive the remaining traits.
5e158c1
@emilio
macros: Some cleanup.
9a0557c 
Remove unused dependencies and such.
@emilio
macros: Ensure the structs are repr(C) and the unit field is public.
bd61d85 
We could relax these if necessary, but for this PR we should preserve behavior.
@emilio
Remove define_matrix!
Loading status checks…
a2a2704
@emilio
Copy link
Member Author

emilio commented Jan 12, 2019

r? @nox / @kvark / @nical
@emilio
macros: Make it build with rust 1.23.
Loading status checks…
9e0f245
@emilio
Copy link
Member Author

emilio commented Jan 12, 2019

@bors-servo r=nox

We could use a #[proc_macro_attribute] to generate the _unit field, but that's unstable in rustc 1.23 which is the current supported version, and it's not that much of a benefit. We could also generate #[repr(C)] but that would confuse cbindgen.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2019

📌 Commit 9e0f245 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2019

⌛ Testing commit 9e0f245 with merge cc2b285...
bors-servo added a commit that referenced this pull request Jan 12, 2019
@bors-servo
Auto merge of #314 - servo:proc-macro, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cc2b285 
Replace the `define_matrix!` macro using a proc macro.

This will allow `cbindgen` to parse this without macro expansion, which will allow us to do it much faster, and at build-time.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/314)
<!-- Reviewable:end -->
@emilio emilio mentioned this pull request Jan 12, 2019
Open
@bors-servo
Copy link
Contributor

bors-servo commented Jan 12, 2019

☀️ Test successful - checks-travis
Approved by: nox
Pushing cc2b285 to master...
@bors-servo bors-servo merged commit 9e0f245 into master Jan 12, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jan 12, 2019
Closed
@emilio emilio deleted the proc-macro branch Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@emilio @bors-servo
You can’t perform that action at this time.