Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive all the things for UnknownUnit #318

Merged
merged 1 commit into from Feb 17, 2019
Merged

Derive all the things for UnknownUnit #318

merged 1 commit into from Feb 17, 2019

Conversation

@fitzgen
Copy link
Member

fitzgen commented Feb 16, 2019

r? @nical


This change is Reviewable

@fitzgen fitzgen requested a review from nical Feb 16, 2019
@nical
Copy link
Collaborator

nical commented Feb 17, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2019

📌 Commit 5ba1098 has been approved by nical

@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2019

Testing commit 5ba1098 with merge e671e5b...

bors-servo added a commit that referenced this pull request Feb 17, 2019
Derive all the things for UnknownUnit

r? @nical

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/318)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 17, 2019

☀️ Test successful - checks-travis
Approved by: nical
Pushing e671e5b to master...

@bors-servo bors-servo merged commit 5ba1098 into master Feb 17, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@fitzgen fitzgen deleted the fitzgen-patch-1 branch Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.