Skip to content

/ euclid

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypedBox3D::contains #323

Merged
merged 1 commit into from Mar 7, 2019
Merged

Fix TypedBox3D::contains #323

merged 1 commit into from Mar 7, 2019
+2 −2

Conversation

@nical
Copy link
Collaborator

nical commented Mar 7, 2019 •
edited by larsbergstrom

This change is Reviewable
@nical
Fix TypedBox3D::contains.
Loading status checks…
3d1fb28
@nical
Copy link
Collaborator Author

nical commented Mar 7, 2019

Same mistake spotted by @kvark in TypedBox2D's review.

r? @kvark
@kvark
kvark approved these changes Mar 7, 2019
View changes
@kvark
Copy link
Member

kvark commented Mar 7, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

📌 Commit 3d1fb28 has been approved by kvark
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

⌛ Testing commit 3d1fb28 with merge 8a5f221...
bors-servo added a commit that referenced this pull request Mar 7, 2019
@bors-servo
Auto merge of #323 - nical:box3d-fix, r=kvark
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8a5f221 
Fix TypedBox3D::contains

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/323)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2019

☀️ Test successful - checks-travis
Approved by: kvark
Pushing 8a5f221 to master...
@bors-servo bors-servo merged commit 3d1fb28 into servo:master Mar 7, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nical @kvark @bors-servo
You can’t perform that action at this time.